Add config option "USE_HOST_HEADER" #32564
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
Resolves go-gitea#32554 This option can be set to make Gitea always use the "Host" request header for construction of absolute URLs.
jannispl
force-pushed
the
use-host-header-option
branch
from
4cd475f to
af5b150
Compare
|
Thank you very much! There is an idea in my mind that maybe we could introduce a more general option than a bool "USE_HOST_HEADER" (actually it not only affects "host header", but also "scheme", so maybe it needs a better name). Will think about later (when I have some time) 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #32554