Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CloseIssue and ReopenIssue instead of ChagneStatus for issues #32467

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Use CloseIssue and ReopenIssue instead of ChagneStatus for issues #32467

wants to merge 8 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 10, 2024 •
edited
Loading

The behaviors of closing issues and reopening issues are very different. So splitting it into two different functions makes it easier to maintain.

  • Split ChangeIssueStatus into CloseIssue and ReopenIssue both at service layer and model layer
  • Rename isClosed to CloseOrReopen to make it more readable.
  • Add transactions for ReopenIssue and CloseIssue

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 10, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lunny @GiteaBot