Fix get reviewers' bug #32415
Merged
Fix get reviewers' bug #32415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
added
type/bug
backport/v1.22
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
the
modifies/api
yp05327
reviewed
Nov 7, 2024
yp05327
reviewed
Nov 7, 2024
kdumontnu
approved these changes
Nov 21, 2024
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Nov 22, 2024
GiteaBot
added
lgtm/done
|
@wxiaoguang are you okay adding back the 1.22 backport? This is a pretty clear & significant bug fix. |
|
No block from my side since you have reviewed. 🙏 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 22, 2024
* giteaofficial/main: Fix get reviewers' bug (go-gitea#32415) Fix issues with inconsistent spacing in areas (go-gitea#32607) Refactor markup render system (go-gitea#32589) Style unification for the issue_management area (go-gitea#32605) Enhancing Gitea OAuth2 Provider with Granular Scopes for Resource Access (go-gitea#32573)
|
I was unable to create a backport for 1.22. @lunny, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Nov 22, 2024
This PR rewrites `GetReviewer` function and move it to service layer. Reviewers should not be watchers, so that this PR removed all watchers from reviewers. When the repository is under an organization, the pull request unit read permission will be checked to resolve the bug of Fix go-gitea#32394
lunny
added a commit
that referenced
this pull request
Nov 23, 2024
This PR rewrites `GetReviewer` function and move it to service layer. Reviewers should not be watchers, so that this PR removed all watchers from reviewers. When the repository is under an organization, the pull request unit read permission will be checked to resolve the bug of Fix #32394 Backport #32415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites
GetReviewerfunction and move it to service layer.Reviewers should not be watchers, so that this PR removed all watchers from reviewers. When the repository is under an organization, the pull request unit read permission will be checked to resolve the bug of #32394
Fix #32394