Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and merge some functions about issue #32178

Closed
wants to merge 9 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 2, 2024

  • Merge updateAttachments and Comment.UpdateAttachments as UpdateCommentAttachments. They are duplicated.
  • Split issues_model.UpdateComment as two parts, one moved to service layer and keep the simple one in issue_model.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 2, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 2, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 2, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Oct 2, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 17, 2024
@lunny
Copy link
Member Author

lunny commented Dec 30, 2024

Closed as two refactor parts have been extracted.

@lunny lunny closed this Dec 30, 2024
@lunny lunny deleted the lunny/refactor-issue branch December 30, 2024 03:47
@lunny lunny removed this from the 1.24.0 milestone Dec 30, 2024
lunny added a commit that referenced this pull request Dec 30, 2024
No code change.
Extract from #32178
lunny added a commit that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants