feat: port html go internal package #2802
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2802 +/- ##
=======================================
Coverage 60.85% 60.85%
=======================================
Files 563 563
Lines 75193 75193
=======================================
+ Hits 45759 45761 +2
+ Misses 26070 26069 -1
+ Partials 3364 3363 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Villaquiranm
force-pushed
the
feat/implement-html-package
branch
from
2b7396b
to
ee01d0c
Compare
There was a problem hiding this comment.
I suggest you do another PR which adds support for strings.Replacer, and then re-base this one on top of that.
- We should not introduce more "temporary" code in the standard library, when we are gearing up towards mainnet.
- This code has the fault of being "iterative" on the replacements; ie.
NewReplacer("a", "bb", "b", "cc").Replace("a")returnsccccrather thanbb.
There was a problem hiding this comment.
You're right thanks for the review :)
| var entity2 map[string][2]rune | ||
|
|
||
| // populateMapsOnce guards calling populateMaps. | ||
| var populateMapsOnce bool |
There was a problem hiding this comment.
Can we remove this bool and check by the map size?
There was a problem hiding this comment.
Or maybe you can populate these maps directly in the declaration? It is guaranteed to be initialized only once.
Why is populateMaps necessary ?
related to #1267
Maybe we should optimize it ? I did not wanted to do something complex as this is not the main point of this pull request
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description