feat(tm2): Print commit duration when broadcasting transaction

[linhpn99]

The execution time is measured in milliseconds and is printed alongside the transaction details. We also consider adding a flag to control whether this information is printed or not

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.42%. Comparing base (f04ec89) to head (9127902).

Files with missing lines	Patch %	Lines
tm2/pkg/crypto/keys/client/broadcast.go	0.00%	4 Missing ⚠️
tm2/pkg/crypto/keys/client/maketx.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2775      +/-   ##
==========================================
- Coverage   60.44%   60.42%   -0.02%     
==========================================
  Files         563      563              
  Lines       75159    75167       +8     
==========================================
- Hits        45427    45422       -5     
- Misses      26343    26354      +11     
- Partials     3389     3391       +2     

Flag	Coverage Δ
contribs/gnodev	60.65% <ø> (-0.82%)	⬇️
gno.land	67.21% <ø> (ø)
gnovm	64.46% <ø> (ø)
misc/genstd	80.54% <ø> (ø)
misc/logos	20.23% <ø> (+0.35%)	⬆️
tm2	62.03% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zivkovicmilos]

@linhpn99

This isn't actually execution time, it's the commit time for the transaction (the time between it was sent, and when it was committed to the chain)

[linhpn99]

@linhpn99

This isn't actually execution time, it's the commit time for the transaction (the time between it was sent, and when it was committed to the chain)

Yep, the general idea is that users are concerned about how long it takes to execute an onchain call using gnokey with the broadcast flag

What do you think should be changed about it? Renamed to "COMMIT DURATION"

[moul]

If we want to add benchmarking metrics, let's create a single line with more information, such as:

PERF: processing=650ms commit=695ms foo=123ms total=1.4s