-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring ES6 #533
base: develop
Are you sure you want to change the base?
Refactoring ES6 #533
Conversation
Add progress bar
Add folio mode
Some small improvements
Add controls disabled function Add state handling
This is awesome. Glad to see there's still life and interest in this project. Is there a README or documentation on the additional functionality? |
@utdrmac No not yet. The options are (with defaults): const defaults = {
sourceUrl: null,
ratio: '4:3',
highlightStyle: 'default',
highlightLines: false,
highlightSpans: false,
highlightInlineCode: false,
highlightLanguage: '',
slideNumberFormat: '%current% / %total%',
cloneTarget: '_blank',
excludedClasses: [],
countIncrementalSlides: true,
macros: {},
transition: false,
transitionSpeed: false,
slideNumber: false,
progressBar: false,
controls: false,
controlsTutorial: false,
controlsLayout: 'bottom-right',
controlsBackArrows: 'faded',
folio: false,
allowControl: true,
navigation: {},
translations: {}
}; For the ported settings (controls, transition, progress bar), see https://github.com/hakimel/reveal.js/#configuration. |
Did you upgrade to the most recent version of marked or did you possibly switch to using CommonMark? |
Edit: Sorry I over read the that you asked for the update of marked. No I don't. |
I updated to marked 0.4.0, options for marked can be set using |
I'm not a github/git guru. What's the best way to test this PR? |
I made an archive for you: https://github.com/GM-Alex/remark/releases/download/es6-rework/remark-es6.zip I also add an easy way to use columns just use |
@GM-Alex That's great works. Since the author has dropped maintenance of remarkjs, could you contact the author to transfer this project to you? |
I made a simple test, find that when
|
This is a refactored version using ES6, adds i18n support, switches from less to sass, uses webpack, ports the slide transitions, the progress bar and the controls from reveal.js and adds some additional functionality. Maybe this could be used some day.