health-report: Add gluster mem usage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Susant Palai <[email protected]>
amarts
reviewed
Jul 12, 2018
| cmd = "cat /proc/`pgrep %s`/status | grep -i vmrss | awk '{print $2}'" % (i) | ||
| out = command_output(cmd) | ||
| ctx.ok("Glusterd ResMem in kB", memory=out.strip()) | ||
|
|
There was a problem hiding this comment.
I expect to have some suggestions on what is the ideal memory usage? Say anything below 1GB is in OK range. anything with >1GB -- 3GB is 'warn', and above '3GB' as notok?
| # General Public License, version 3 or any later version (LGPLv3 or | ||
| # later), or the GNU General Public License, version 2 (GPLv2), in all | ||
| # cases as published by the Free Software Foundation. | ||
|
|
There was a problem hiding this comment.
looks like we don't need any headers. Can you check?
|
This looks like a good feature to have, can this be worked on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Susant Palai [email protected]