Skip to content

Conversation

@deepshikhaaa
Copy link
Member

The list is similar to what we run on gerrit. Let me know if there is any other job to be included.

The list is similar to what we run on gerrit.
@mscherer
Copy link
Collaborator

mscherer commented Oct 8, 2020

So, as discussed on IRC, I would need a better answer than "we did it before". I think that given that's a different codebase, we need to verify it build like on devel.

@itisravi
Copy link
Member

Hello. Are we taking this PR in? Both fedora-smoke and python compliance are failing for PRs against release branches

@deepshikhaaa
Copy link
Member Author

Only the fedora-smoke is disabled for release-N branches.

Do you see any new failure?

@itisravi
Copy link
Member

Only the fedora-smoke is disabled for release-N branches.

Do you see any new failure?

Yes for gluster/glusterfs#1561, both smoke and python compliance failed.

@itisravi
Copy link
Member

gluster/glusterfs#1562 too..

@deepshikhaaa
Copy link
Member Author

So python-compliance failed 4 days ago if you check the jenkins job details. It is also not required to pass for merge. So we are good with python-compliance.

fedora-smoke is also not running for recent triggers on PR #1562, it did fail before and is a part of branch protection rule. So your PR stucked there. I'm looking for a way of how to get away with fedora-smoke failure on this PR. I don't want to change the setting as a whole for the branch protection rule.

@itisravi
Copy link
Member

It is also not required to pass for merge. So we are good with python-compliance.

Ah okay got it.

@mscherer
Copy link
Collaborator

But so, why are we blocking the test on release ? I get that it fail on current release for some test, but I think that this should be restricted on those tests and those release. For example, if freebsd-smoke is fine, then it should be run on release branch as well. If release-X is fine but not X-1, then we shouldn't use '*'.

Base automatically changed from master to main February 17, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants