Skip to content

Conversation

@rydb
Copy link

@rydb rydb commented Dec 17, 2024

I am trying to use this library to serialize meshes for my project into the gltf format. In order to confirm I'm doing it correctly, I would like to compare a mesh gltf imported from a working exporter, and the mesh gltf exported from the one I'm working on.

However, currently, I cannot compare gltf files as Root does not implement PartialEq

This pr resolves this by implementing PartialEq on Root and all attributes that Root uses.

@rydb rydb changed the title implement PartialEq on Root and its attributes Add support for comparing gltfs by implementing PartialEq on Root Dec 17, 2024
@rydb
Copy link
Author

rydb commented Jan 13, 2025

tried to test the check failures locally with act and I'm getting these two errors

[Tests/Run test]   ❗  ::error::Input required and not supplied: token
[Tests/Run test]   ❌  Failure - Main Checkout glTF Sample Assets

not sure how to fix this.

@rydb
Copy link
Author

rydb commented Jan 13, 2025

tried to test the check failures locally with act and I'm getting these two errors

[Tests/Run test]   ❗  ::error::Input required and not supplied: token
[Tests/Run test]   ❌  Failure - Main Checkout glTF Sample Assets

not sure how to fix this.

gave test suite auth token and this bug went away. Now waiting on:
serde-rs/json#1227

to be merged to finish this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants