Pull request dedicated to support analysis and integration of the functional modules designed for ANAC project 2024 #4313 #4314
2 new security issues (1 max.).
Issues
======
+ Solved 47
- Added 127
Complexity increasing per file
==============================
- client/app/src/shared/partials/org-recipient-info/org-recipient-info.component.ts 1
- client/app/src/pages/analyst/reports/reports.component.ts 7
- client/app/src/pages/accreditor/sidebar/sidebar.component.ts 1
- client/app/src/shared/partials/selecteo-dropdown/selecteo-dropdown.component.ts 1
- client/app/src/shared/partials/tip-eo-comments/tip-eo-comments.component.ts 4
- client/app/src/shared/guards/accreditor.guard.ts 3
- client/app/src/shared/partials/org-info/org-info.component.ts 6
- client/app/src/shared/partials/org-admin-info/org-admin-info.component.ts 1
- client/app/src/pages/recipient/accreditation-request/accreditation-request.component.ts 2
- backend/globaleaks/utils/backup.py 3
- client/app/src/shared/partials/sendtip-file-upload/sendtip-file-upload.component.ts 3
- client/app/src/pages/accreditor/organizations/organizations.component.ts 3
- backend/globaleaks/handlers/accreditator/utils.py 3
- client/app/src/pages/recipient/recipient.guard.ts 2
- backend/globaleaks/handlers/accreditator/services.py 5
- client/app/src/shared/partials/tip-eo-form/tip-eo-form.component.ts 3
- backend/globaleaks/utils/file_analysis/ScanResponse.py 2
- client/app/src/shared/partials/tip-field-question-entry/tip-field-question-entry.component.ts 6
- client/app/src/shared/partials/sendtip-files/sendtip-files.component.ts 5
- backend/globaleaks/utils/file_analysis/__init__.py 4
- client/app/src/pages/accreditor/organization/organization.component.ts 7
- client/app/src/shared/partials/org-overview/org-overview.component.ts 1
- client/app/src/pages/accreditor/home/home.component.ts 4
- backend/globaleaks/handlers/accreditator/__init__.py 3
- backend/globaleaks/tests/handlers/accreditation.py 2
- client/app/src/models/reciever/sendtip-data.ts 1
- client/app/src/pages/admin/backup/backup.component.ts 1
- backend/globaleaks/utils/file_analysis/ScanData.py 2
- client/app/src/shared/resolvers/accreditation-req-resolver.service.ts 2
- client/app/src/pages/recipient/sendtip/sendtip.component.ts 4
- backend/globaleaks/utils/file_analysis/VirusScanResult.py 2
- client/app/src/shared/partials/org-users-list/org-users-list.component.ts 1
- client/app/src/pages/recipient/tip-eo/tip-eo.component.ts 6
- client/app/src/pages/recipient/sendtip-detail/sendtip-detail.component.ts 3
- client/app/src/shared/partials/tip-eo-list/tip-eo-list.component.ts 1
- client/app/src/shared/modals/custom-modal/custom-modal.component.ts 2
- client/app/src/pages/accred/accred/accred.component.ts 5
- backend/globaleaks/handlers/accreditator/fw_mail.py 6
- client/app/src/shared/modals/download-confirmation/download-confirmation.component.ts 1
- backend/globaleaks/utils/file_analysis/utils.py 2
- backend/globaleaks/handlers/recipient/sendtip.py 4
- client/app/src/shared/partials/tip-eo-rfiles-receiver/tip-eo-rfiles-receiver.component.ts 1
- backend/globaleaks/jobs/backup.py 3
- client/app/src/pages/admin/backup/backup-tab1/backup-tab1.component.ts 2
- client/app/src/shared/partials/sendtip-detail-questionnaire-answers/sendtip-detail-questionnaire-answers.component.ts 1
- client/app/src/services/helper/accreditor-org.service.ts 1
- backend/globaleaks/db/migrations/update_69/__init__.py 2
- client/app/src/pages/admin/questionnaires/fields/fields.component.ts 5
- client/app/src/shared/partials/rfile-upload-button/r-file-upload-button.component.ts 1
- client/app/src/services/root/app-interceptor.service.ts 1
- client/app/src/pages/admin/users/users-tab1/users-tab1.component.ts 1
- backend/globaleaks/handlers/analyst/__init__.py 1
- backend/globaleaks/handlers/secret.py 4
- backend/globaleaks/handlers/user/__init__.py 1
- backend/globaleaks/handlers/admin/user.py 1
- backend/globaleaks/state.py 1
- backend/globaleaks/handlers/public.py 1
Complexity decreasing per file
==============================
+ client/app/src/pages/admin/users/user-editor/user-editor.component.ts -1
+ client/app/src/services/helper/authentication.service.ts -1
+ backend/globaleaks/handlers/whistleblower/submission.py -1
+ backend/globaleaks/handlers/recipient/__init__.py -2
+ backend/globaleaks/handlers/recipient/export.py -6
+ backend/globaleaks/orm.py -7
+ backend/globaleaks/tests/test_api.py -2
+ backend/globaleaks/handlers/admin/operation.py -5
+ backend/globaleaks/models/serializers.py -7
Clones added
============
- client/app/src/pages/analyst/reports/reports.component.ts 1
- client/app/src/pages/accreditor/sidebar/sidebar.component.ts 1
- client/app/src/shared/partials/tip-eo-comments/tip-eo-comments.component.ts 2
- client/app/src/shared/guards/accreditor.guard.ts 2
- client/app/src/shared/partials/tip-field-question-entry/tip-field-question-entry.component.ts 5
- client/app/src/pages/accreditor/organization/organization.component.ts 2
- client/app/src/pages/accreditor/home/home.component.ts 1
- backend/globaleaks/handlers/accreditator/__init__.py 3
- client/app/src/pages/recipient/tip-eo/tip-eo.component.ts 13
- backend/globaleaks/handlers/accreditator/fw_mail.py 2
- client/app/src/shared/modals/download-confirmation/download-confirmation.component.ts 2
- backend/globaleaks/handlers/recipient/sendtip.py 2
- backend/globaleaks/db/migrations/update_69/__init__.py 29
- client/app/src/pages/recipient/tips/tips.component.ts 3
- client/app/src/shared/partials/wbfiles/wb-files.component.ts 2
- client/app/src/pages/whistleblower/submission/submission.component.ts 1
- client/app/src/shared/services/utils.service.ts 5
- client/app/src/shared/partials/tip-comments/tip-comments.component.ts 2
- client/app/src/shared/services/tip-service.ts 2
- client/app/src/models/app/shared-public-model.ts 1
- client/app/src/pages/recipient/tip/tip.component.ts 1
- client/app/src/shared/partials/tip-files-whistleblower/tip-files-whistleblower.component.ts 1
- client/app/src/models/resolvers/questionnaire-model.ts 1
- client/app/src/models/resolvers/field-template-model.ts 1
- backend/globaleaks/tests/handlers/analyst/test_analyst.py 2
- backend/globaleaks/handlers/auth/__init__.py 1
- backend/globaleaks/handlers/whistleblower/wbtip.py 2
- backend/globaleaks/handlers/recipient/rtip.py 2
- backend/globaleaks/models/__init__.py 3
- backend/globaleaks/models/serializers.py 2
Clones removed
==============
+ client/app/src/pages/analyst/analyst-routing.module.ts -1
+ client/app/src/pages/admin/settings/tab2/tab2.component.ts -1
+ client/app/src/pages/recipient/recipient-routing.module.ts -1
+ client/app/src/pages/admin/users/user-editor/user-editor.component.ts -1
+ client/app/src/models/whistleblower/wb-tip-data.ts -1
+ client/app/src/shared/partials/tip-upload-wbfile/tip-upload-wb-file.component.ts -1
See the complete overview on Codacy
Annotations
Check notice on line 13 in backend/globaleaks/db/migrations/update_69/__init__.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/db/migrations/update_69/__init__.py#L13
'Column' may be undefined, or defined from star imports: globaleaks.models.properties (F405)
Check notice on line 16 in backend/globaleaks/db/migrations/update_69/__init__.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/db/migrations/update_69/__init__.py#L16
'Column' may be undefined, or defined from star imports: globaleaks.models.properties (F405)
Check notice on line 18 in backend/globaleaks/db/migrations/update_69/__init__.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/db/migrations/update_69/__init__.py#L18
'Column' may be undefined, or defined from star imports: globaleaks.models.properties (F405)
Check notice on line 156 in backend/globaleaks/db/migrations/update_69/__init__.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/db/migrations/update_69/__init__.py#L156
'Column' may be undefined, or defined from star imports: globaleaks.models.properties (F405)
Check notice on line 165 in backend/globaleaks/db/migrations/update_69/__init__.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/db/migrations/update_69/__init__.py#L165
'Column' may be undefined, or defined from star imports: globaleaks.models.properties (F405)
Check notice on line 170 in backend/globaleaks/db/migrations/update_69/__init__.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/db/migrations/update_69/__init__.py#L170
'Column' may be undefined, or defined from star imports: globaleaks.models.properties (F405)
Check warning on line 146 in backend/globaleaks/handlers/accreditator/services.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/accreditator/services.py#L146
Consider explicitly re-raising using 'except NoResultFound as exc' and 'raise errors.ResourceNotFound from exc'
Check warning on line 101 in backend/globaleaks/handlers/admin/tenant.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/admin/tenant.py#L101
Bad indentation. Found 16 spaces, expected 12
Check notice on line 156 in backend/globaleaks/handlers/admin/user.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/admin/user.py#L156
Too many positional arguments (6/5)
Check notice on line 79 in backend/globaleaks/handlers/auth/__init__.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/auth/__init__.py#L79
Import outside toplevel (scrypt)
Check notice on line 275 in backend/globaleaks/handlers/base.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/base.py#L275
Formatting a regular string which could be an f-string
Check notice on line 10 in backend/globaleaks/handlers/recipient/rtip.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/recipient/rtip.py#L10
'pyexpat.model' imported but unused (F401)
Check notice on line 1101 in backend/globaleaks/handlers/recipient/rtip.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/recipient/rtip.py#L1101
Too many positional arguments (6/5)
Check notice on line 1121 in backend/globaleaks/handlers/recipient/rtip.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/recipient/rtip.py#L1121
instead of list()
Check failure on line 1545 in backend/globaleaks/handlers/recipient/rtip.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/recipient/rtip.py#L1545
Possibly using variable 'file_forwarding' before assignment
Check notice on line 1596 in backend/globaleaks/handlers/recipient/rtip.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/recipient/rtip.py#L1596
Too many positional arguments (6/5)
Check notice on line 75 in backend/globaleaks/handlers/recipient/sendtip.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/recipient/sendtip.py#L75
Consider using '{}' instead of a call to 'dict'.
Check warning on line 11 in backend/globaleaks/handlers/secret.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/secret.py#L11
Using open without explicitly specifying an encoding
Check notice on line 96 in backend/globaleaks/handlers/whistleblower/submission.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/whistleblower/submission.py#L96
Too many positional arguments (6/5)
Check notice on line 176 in backend/globaleaks/handlers/whistleblower/submission.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/whistleblower/submission.py#L176
Consider using '{}' instead of a call to 'dict'.
Check notice on line 274 in backend/globaleaks/handlers/whistleblower/wbtip.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/whistleblower/wbtip.py#L274
Formatting a regular string which could be an f-string
Check warning on line 4 in backend/globaleaks/handlers/wizard.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/handlers/wizard.py#L4
Unused import json
Check warning on line 4 in backend/globaleaks/jobs/backup.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/jobs/backup.py#L4
Consider possible security implications associated with the subprocess module.
Check notice on line 15 in backend/globaleaks/jobs/backup.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/jobs/backup.py#L15
'twisted.internet.defer.inlineCallbacks' imported but unused (F401)
Check notice on line 330 in backend/globaleaks/models/serializers.py
codacy-production / Codacy Static Code Analysis
backend/globaleaks/models/serializers.py#L330
Consider using '{}' instead of a call to 'dict'.