Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TS and modernize build #1667

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
83365f2
Update TS and modernize build
wycats Nov 23, 2024
75a672e
Fix publints
wycats Dec 2, 2024
721cbb2
Merge branch 'main' into infra/modernize-build
wycats Dec 2, 2024
8bb696e
Improve type smoke tests (not finished yet)
wycats Dec 2, 2024
3523ae0
Implement @glimmer/engine and /fundamental
wycats Dec 4, 2024
a87bf99
Fix some import mistakes
wycats Dec 6, 2024
1af74fe
Don't inline yet
wycats Dec 6, 2024
408eca7
Fix more import mistakes
wycats Dec 6, 2024
5d29d17
Improve correctness of `@glimmer/fundamental`
wycats Dec 7, 2024
ae71757
Strict types
wycats Dec 10, 2024
4c4f7ba
isolatedDeclarations and remove unused things
wycats Dec 11, 2024
9372d78
Implement meta-updater
wycats Dec 11, 2024
bc6d7dd
Prettier
wycats Dec 11, 2024
4d4f2d3
More meta update
wycats Dec 12, 2024
222ba61
More meta-updater improvements
wycats Dec 12, 2024
8adb8ba
More meta-update and lint cleanup
wycats Dec 13, 2024
a4c0d59
Convert wire format to constants and inline it
wycats Dec 16, 2024
5db735c
Document and improve meta-updater
wycats Dec 18, 2024
9ef4f53
Improvements to meta-updater and the bench setup
wycats Dec 19, 2024
e76025d
More meta-updater improvements
wycats Dec 19, 2024
dc07147
More bench improvements
wycats Dec 20, 2024
97077f4
Try to speed up clearing
wycats Dec 21, 2024
11ab3dc
Fix bench env mistake
wycats Dec 21, 2024
a2540d8
Bring back terser to bench setup
wycats Dec 21, 2024
599c09c
Adjust @glimmer/state strategy
wycats Dec 21, 2024
6af718c
Try a terser annotation
wycats Dec 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Try a terser annotation
wycats committed Dec 21, 2024
commit 6af718c8bce44099bc6ec363c268c660e9f65320
20 changes: 12 additions & 8 deletions packages/@glimmer/runtime/lib/opcodes.ts
Original file line number Diff line number Diff line change
@@ -170,16 +170,20 @@ class AppendOpcodes {
let operation = unwrap(this.evaluateOpcode[type]);

if (operation.syscall) {
assert(
!opcode.isMachine,
`BUG: Mismatch between operation.syscall (${operation.syscall}) and opcode.isMachine (${opcode.isMachine}) for ${opcode.type}`
);
if (LOCAL_DEBUG) {
assert(
!opcode.isMachine,
`BUG: Mismatch between operation.syscall (${operation.syscall}) and opcode.isMachine (${opcode.isMachine}) for ${opcode.type}`
);
}
operation.evaluate(vm, opcode);
} else {
assert(
opcode.isMachine,
`BUG: Mismatch between operation.syscall (${operation.syscall}) and opcode.isMachine (${opcode.isMachine}) for ${opcode.type}`
);
if (LOCAL_DEBUG) {
assert(
opcode.isMachine,
`BUG: Mismatch between operation.syscall (${operation.syscall}) and opcode.isMachine (${opcode.isMachine}) for ${opcode.type}`
);
}
operation.evaluate(vm.lowlevel, opcode);
}
}

Unchanged files with check annotations Beta

import { meta, type TagMeta } from '@glimmer/state';

Check failure on line 1 in packages/@glimmer/fundamental/lib/tag-meta.ts

GitHub Actions / Linting

Prefer using a top-level type-only import instead of inline type specifiers
export function upsertTagMetaFor(obj: object): TagMeta {
let tags = meta.get(obj);