Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Go template functions #385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add more Go template functions #385

wants to merge 4 commits into from

Conversation

kwent
Copy link

@kwent kwent commented Mar 19, 2018

Add more template functions

michaelshobbs
michaelshobbs requested changes Mar 20, 2018
View reviewed changes
Copy link
Member

@michaelshobbs michaelshobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs docs and tests

@kwent kwent force-pushed the template_functions branch 3 times, most recently from 1c25e25 to 3eb1138 Compare March 20, 2018 03:22
@kwent
Copy link
Author

kwent commented Mar 20, 2018

@michaelshobbs Added docs + tests

@kwent
Copy link
Author

kwent commented Mar 20, 2018 •
edited
Loading

Actually shall we not just use https://github.com/Masterminds/sprig ? Thoughts ?

@gbolo
Copy link
Collaborator

gbolo commented Aug 18, 2018

@kwent I would support the use of github.com/Masterminds/sprig. Good call!

@kwent
Copy link
Author

kwent commented May 26, 2020

Are you guys planning on integrating https://github.com/Masterminds/sprig ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelshobbs michaelshobbs michaelshobbs requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwent @gbolo @michaelshobbs