Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I am not sure if there’s actually interest in this, but I thought I’d share an idea as a PR and we can take it from here.)
I am using QuickType to generate Rust structs so I can parse a LDTK file (a JSON blob) that is bundled with my binary. Since the JSON blob is already embedded in the binary, it seems wasteful to use
String
. Instead, for most intents and purposes, it’s functionally identical to useCow<'_, str>
instead ofString
, but without having to copy all the strings to the heap.This PR adds a new
--use-cow
option for Rust, which replaces the occurrences ofString>
withCow<'a, str>
. Because of the introduction of lifetimes, there is also a bit of machinery as a struct containing a string now needs to have a lifetime itself, and this needs to be recursively propagate up the type tree.Example before/after
Before:After: