Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies and use wisp_mist.handler() #32

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

inmanturbo
Copy link

@inmanturbo inmanturbo commented Oct 8, 2024

fixes #31

Edit: Draft for now until I get time to properly define dependencies (see conversation below), but note that upgrading to latest wisp requires using wisp/wisp_mist.handler() in place of wisp.mist_handler()

@inmanturbo inmanturbo changed the title update dependencies and use wisp_mist.handle() update dependencies and use wisp_mist.handler() Oct 8, 2024
gleam_crypto = "~> 1.3"
sqlight = "~> 0.9"
mist = ">= 1.2.0"
wisp = ">= 1.0.0"
Copy link
Member

@lpil lpil Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

Typically one does not edit this file to upgrade dependencies unless the desired version is outside the specified range, you can run gleam update instead.

Seeing as they are edited, please convert all the requirements from the ~> syntax and specify an upper bound of the next major version for all of them. Thank you.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have ever little experience with gleam. I did try gleam update but I was having issues resolving a set of dependencies that would compile together. I did some digging around in hex and found a set that worked for me.

I will try again little later to get it working by resetting the file and using gleam update, or otherwise applying your recommendations above!

Thanks again and thanks for the language as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project is locked to working versions, so if you revert all your changes and run gleam run it will work with current Gleam.

You only need to make changes if you decide that you want to upgrade the dependencies.

@inmanturbo inmanturbo marked this pull request as draft October 9, 2024 13:36
@inmanturbo
Copy link
Author

Marking as draft for now. This isn't actually fixing a bug, but some small changes are needed in main to upgrade wisp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not compile with gleam 1.5.1
2 participants