Stop relying on call_atomic #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
glacambre
commented
Apr 28, 2024
glacambre
commented
- src/frame.ts: replace nvim_call_atomic with nvim_exec_lua
- src/Neovim.ts: stop filtering out deprecated functions.
Fixes #1603, and much cleaner anyway.
glacambre
force-pushed
the
fix-1603
branch
3 times, most recently
from
c808085 to
4c02c13
Compare
A vim.ui_attach function whose interface differs from nvim_ui_attach was introduced in 0.9, and would overwrite nvim_ui_attach for Firenvim. The only reason this didn't cause any issues yet is that vim.ui_attach is marked deprecated, but we can't ignore deprecated functions because otherwise Firenvim breaks immediately when functions get deprecated (e.g. which is what happened in #1603).
glacambre
force-pushed
the
fix-1603
branch
2 times, most recently
from
7d7d908 to
cbe40cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.