Adds threshold filter to the new home view #3718
Open
+195
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzaytsev
force-pushed
the
features/3706-filtering-of-branches-in-home-view
branch
2 times, most recently
from
7beb06e
to
a52d3fb
Compare
d13
reviewed
Nov 8, 2024
Comment on lines
71
to
79
| @gl-change=${(e: CustomEvent<{ threshold: OverviewRecentThreshold }>) => { | ||
| if (!this._overviewState.filter.stale || !this._overviewState.filter.recent) { | ||
| return; | ||
| } | ||
| this._ipc.sendCommand(SetOverviewFilter, { | ||
| stale: this._overviewState.filter.stale, | ||
| recent: { ...this._overviewState.filter.recent, threshold: e.detail.threshold }, | ||
| }); | ||
| }} |
There was a problem hiding this comment.
Nit: move the event handler to a private method for readability
Comment on lines
37
to
57
| @property({ type: Array }) options: (OverviewRecentThreshold | OverviewStaleThreshold)[] | undefined; | ||
| private selectDateFilter(threshold: OverviewRecentThreshold | OverviewStaleThreshold) { | ||
| const event = new CustomEvent('gl-change', { | ||
| detail: { threshold: threshold }, | ||
| }); | ||
| this.dispatchEvent(event); | ||
| } | ||
|
|
||
| private renderOption(option: OverviewRecentThreshold | OverviewStaleThreshold) { | ||
| switch (option) { | ||
| case 'OneDay': | ||
| return '1 day'; | ||
| case 'OneWeek': | ||
| return '1 week'; | ||
| case 'OneMonth': | ||
| return '1 month'; | ||
| case 'OneYear': | ||
| return '1 year'; | ||
| } | ||
| } |
There was a problem hiding this comment.
Option labels should be passed in as part of the options:
{ label: string; value: OverviewRecentThreshold | OverviewStaleThreshold}[]
src/webviews/home/homeWebview.ts
Outdated
| }, | ||
| stale: { | ||
| threshold: 'OneYear', | ||
| show: true, |
There was a problem hiding this comment.
Stale should be false by default. We don't want to ship stale until post-release of v16.
Comment on lines
+23
to
+27
| display: flex; | ||
| justify-content: space-between; | ||
| gap: 8px; |
There was a problem hiding this comment.
This style is shared with heading that don't have nested <spans>, please make a modifier class to apply the flexbox.
| @@ -40,8 +43,7 @@ export class GlBranchSection extends LitElement { | |||
| override render() { | |||
| return html` | |||
| <div class="section"> | |||
| <h3 class="section-heading">${this.label}</h3> | |||
| <slot></slot> | |||
| <h3 class="section-heading"><span>${this.label}</span><slot></slot></h3> | |||
There was a problem hiding this comment.
Suggested change
| <h3 class="section-heading"><span>${this.label}</span><slot></slot></h3> | |
| <h3 class="section-heading"><span>${this.label}</span><slot name="heading-actions"></slot></h3> | |
| <slot></slot> |
| const { repository } = overview; | ||
| return html` | ||
| <div class="repository"> | ||
| <gl-branch-section | ||
| label="Recent (${repository.branches.recent.length})" | ||
| .branches=${repository.branches.recent} | ||
| ></gl-branch-section> | ||
| > | ||
| <gl-branch-threshold-filter |
There was a problem hiding this comment.
See named-slot comment in branch-section.ts.
Suggested change
| <gl-branch-threshold-filter | |
| <gl-branch-threshold-filter slot="heading-actions" |
Comment on lines
22
to
23
| @customElement('gl-branch-owner-filter') | ||
| export class GlBranchOwnerFilter extends GlElement { |
There was a problem hiding this comment.
Please split out all owner functionality as we will work on this post-release.
nzaytsev
force-pushed
the
features/3706-filtering-of-branches-in-home-view
branch
2 times, most recently
from
5b082d1
to
b7c74ae
Compare
nzaytsev
force-pushed
the
features/3706-filtering-of-branches-in-home-view
branch
from
b7c74ae
to
4f5e3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2024-11-07.at.13.40.33.mov
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses