Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds eslint workflow #3649

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adds eslint workflow #3649

wants to merge 4 commits into from

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Oct 8, 2024

Description

Let's use eslint check for PRs instead of template checkbox

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@axosoft-ramint
Copy link
Contributor

axosoft-ramint commented Oct 10, 2024

I don't have any idea how to test this, so there's not much review I can do here, but I am for adding lint checks to PRs if they aren't there already and if @d13 and @eamodio agree

@axosoft-ramint axosoft-ramint removed their request for review October 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants