Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support git sub directory #345 #382

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tjx666
Copy link

@tjx666 tjx666 commented Aug 23, 2024

This will fix #345.

The codebase now not consider the condition user open a sub directory of one git repo.

Example repo: https://github.com/tjx666/node-action-test

For example you project's path is: /code/repo, but you open vscode at /code/repo/web.

because when you open a sub directory of one git repo, the workflowUri /code/repo/.github/test.yml is outside /code/repo/web, will result code like following will return undefined:

const workspaceFolder = vscode.workspace.getWorkspaceFolder(workflowUri);

Note

I test locally, works fine. The only situation may be problem is:

path.relative(gitRepoFolderUri.path, workflowUri.path);

I don't known whether it will works on web environment.

@tjx666 tjx666 requested a review from a team as a code owner August 23, 2024 07:17
@felipesu19
Copy link
Collaborator

We're not currently approving/merging pull requests for this repo except for security vulnerability/high priority stuff (more on that soon), so no ETA on getting this reviewed. I would highly suggest adding a good pr description though, as that will help when we start triaging what to review 👍

@tjx666
Copy link
Author

tjx666 commented Aug 23, 2024

@felipesu19 I write some description

@tjx666
Copy link
Author

tjx666 commented Aug 27, 2024

seems will not checked recently, I publish my own version here: YuTengjing.vscode-github-actions-pro

@laylow12345 laylow12345 mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't trigger workflow run when in sub directory of git repository
2 participants