Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README example #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix README example #210

wants to merge 1 commit into from

Conversation

owen-c
Copy link

@owen-c owen-c commented Mar 17, 2023

I couldn't find any way a custom Experiment can take a block into initialize, so I don't think this example is correct.

Comment on lines +514 to +516
experiment = MyExperiment.new("various-ways")
experiment.try("first-way") { ... }
experiment.try("second-way") { ... }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's a tap missing?

Suggested change
experiment = MyExperiment.new("various-ways")
experiment.try("first-way") { ... }
experiment.try("second-way") { ... }
experiment = MyExperiment.new("various-ways").tap do |e|
e.try("first-way") { ... }
e.try("second-way") { ... }
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants