Conversation
|
Clean PR — extends the existing tool correctly, uses the right GraphQL mutations, and tests cover the key cases. Ready for merge with minor notes:
Nice work filling a real gap in the PR review workflow. |
08aa18b to
dac1776
Compare
Adds `resolve_thread` and `unresolve_thread` methods to the `pull_request_review_write` tool, enabling users to resolve and unresolve PR review threads via GraphQL mutations. - Add ThreadID field to PullRequestReviewWriteParams struct - Add threadId parameter and new methods to tool schema - Implement ResolveReviewThread function using GraphQL mutations - Add switch cases for resolve_thread and unresolve_thread methods - Add unit tests covering success, error, empty and omitted threadId - Document that owner/repo/pullNumber are unused for these methods - Document idempotency (resolving already-resolved is a no-op) - Update toolsnaps and generated docs Fixes github#1768 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dac1776 to
1fdfa13
Compare
|
I believe the feedback should be addressed. I'm not a frequent contributor to this repo so if there is anything I need to amend just let me know! I squashed the commits as well |
|
Would love to get this feature in - currently when claude et al. are using the github MCP server they can create threads with suggestions but if the suggestion is approved / fixed they can't resolve the thread. It may seem like a small quality of life thing but it's nice when we can get the thread resolved. |
|
We could really use this as well! |
|
Everything is updated, is there anyone who can help with merging or letting me know what to update? |
Summary
Adds
resolve_threadandunresolve_threadmethods to thepull_request_review_writetool, enabling users to resolve and unresolve PR review threads via GraphQL mutations.Why
Fixes #1768
What changed
ThreadIDfield toPullRequestReviewWriteParamsstructthreadIdparameter and new methods to tool schemaResolveReviewThreadfunction using GraphQLresolveReviewThreadandunresolveReviewThreadmutationsresolve_threadandunresolve_threadmethodsMCP impact
resolve_thread,unresolve_thread) and a newthreadIdparameter to the existingpull_request_review_writetool.Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs
script/generate-docs