Remove unused functions in binlog_file.go#1605
Open
grodowski wants to merge 4 commits intogithub:masterfrom
Open
Remove unused functions in binlog_file.go#1605grodowski wants to merge 4 commits intogithub:masterfrom
grodowski wants to merge 4 commits intogithub:masterfrom
Conversation
grodowski
requested review from
meiji163,
rashiq and
timvaillancourt
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes unused code from the binlog_file.go file, cleaning up dead code that is no longer referenced anywhere in the codebase.
- Removes four unused methods:
PreviousFileCoordinatesBy,PreviousFileCoordinates,NextFileCoordinates, andDetachedCoordinates - Removes the unused
detachPatternregex variable and its initialization - Removes unused imports (
errorsandregexp) that were only needed by the deleted code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meiji163
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1604, I noticed there's a bunch of currently unused fns. Please close this if these functions are used for ongoing development 🙇