Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onSuccess hook to run after INSTANT #1463

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

artemvovk
Copy link
Contributor

@artemvovk artemvovk commented Oct 29, 2024

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: #1365

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR fixes that no hooks would run after a successful INSTANT DDL, which is an unexpected behavior.

kind of unclear on how to add tests for this because the migrator and hooks tests are very unrelated, but I can try

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

previously, no hooks would run after a successful INSTANT DDL,
which is an unexpected behavior.
@meiji163 meiji163 merged commit a6ccd3f into github:master Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants