Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the testcontainers setup #1460

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

arthurschreiber
Copy link
Member

Description

This PR attempts to improve the testcontainers ergonomics.

  • Added a new SkipPortValidation on the migration context. This is only used internally and allows skipping the port validation, which is useful with MySQL containers running in docker with a randomly assigned "external" port.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

meiji163
meiji163 previously approved these changes Oct 23, 2024
meiji163
meiji163 previously approved these changes Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants