Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix function names in comment #1405

Merged
merged 2 commits into from
Apr 14, 2024
Merged

chore: fix function names in comment #1405

merged 2 commits into from
Apr 14, 2024

Conversation

mountcount
Copy link
Contributor

@mountcount mountcount commented Apr 9, 2024 •
edited
Loading

Description

fix function names in comment

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

timvaillancourt
timvaillancourt approved these changes Apr 14, 2024
View reviewed changes
Copy link
Collaborator

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mountcount!

@timvaillancourt timvaillancourt added this to the v1.1.7 milestone Apr 14, 2024
@timvaillancourt timvaillancourt merged commit 8d99e46 into github:master Apr 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

@meiji163 meiji163 Awaiting requested review from meiji163 meiji163 is a code owner

Assignees
No one assigned
Labels
low-risk
Projects
None yet
Milestone
v1.1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@mountcount @timvaillancourt