Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the
errcheck
linter in the projectgolangci-lint
config:Also a lot of missing error handling was added for problems (or
// nolint:errcheck
flags for some false-positives). For the most part I have avoided introducing new scenarios where we fail/exit the migration, so in many cases I just-added alog.Errorf(...)
without modifying thereturn
script/cibuild
returns with no formatting errors, build errors or unit test errors.