Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tear down streamer #1153

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RainbowDashy
Copy link

Related issue: #465

Description

The PR #479 introduces "teardown" and make it possible to use gh-ost as a library. However some cleanups are missing.

This PR closes streamer properly when tearing down.

Downstream PR is bytebase#3

@RainbowDashy
Copy link
Author

RainbowDashy commented Jul 28, 2022

After a second thought, I believe that we shouldn’t reuse the CutOverCompleteFlag here, which would stop streaming via canStopStreaming() but to test migrator.finishedMigrating in canStopStreaming() instead. This is more consistent with the existing patterns present in applier , for example.

@timvaillancourt wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants