Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.5 #1144

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

v1.1.5 #1144

wants to merge 25 commits into from

Conversation

@dm-2
Copy link
Contributor Author

dm-2 commented Jul 7, 2022

Merge conflicts are expected due to commits being cherry-picked, this branch will not be merged into master branch on release.

@dm-2 dm-2 added this to the v1.1.5 milestone Jul 7, 2022
@dm-2 dm-2 temporarily deployed to production/mysql_role=ghost_testing July 7, 2022 12:18 Inactive
timvaillancourt
timvaillancourt previously approved these changes Jul 7, 2022
jecepeda and others added 13 commits July 7, 2022 16:21
…t errors (#1127)

* Add `golangci-lint`, fix `gosimple`, `govet` and `unused` linter complaints

* Go 1.16

* Update copyright dates
* compound pk tests

* more details in failure diff

* more elaborate test; the pk-ts one consistently fails

* Fix merge conflict

Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
…)` (#1135)

* Use `switch` statements for readability

* Simplify initBinlogReader()
* Add context/timeout to HTTP throttle check

* Dont run `.GetThrottleHTTPInterval()` on every loop

* Update help message

* Var rename

* 2022

* Add timeout flag

* Add unix/tcp server commands, use ParseInt() for string->int64

* Var rename

* Re-check http timeout on every loop iteration

* Remove stale comment

* Make throttle interval idempotent

* var rename

* Usage grammar

* Make http timeout idempotent too

* Parse time.Duration once

* Move timeout to NewThrottler

* Help update

* Set User-Agent header

* Re-add newline

Co-authored-by: dm-2 <[email protected]>
* Cancel any row count queries before attempting to cut over

Closes #830. Switches from using `QueryRow` to `QueryRowContext`, and
stores a context.CancelFunc in the migration context, which is called to
halt any running row count query before beginning the cut over.

* Make it threadsafe

* Kill the count query on the database side as well

* Explicitly grab a connection to run the count, store its connection id
* When the query context is canceled, run a `KILL QUERY ?` on that connection id

* Rewrite these to use the threadsafe functions, stop exporting the cancel func

* Update logger

* Update logger

Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: dm-2 <[email protected]>
…istics (#844)

* Check RowsAffected when applying DML events to get more accurate statistics

Addresses #600.

When applying a DML event, check the RowsAffected on the `Result`
struct. Since all DML event queries are point queries, this will only
ever be 0 or 1. The applier then takes this value and multiplies by
the `rowsDelta` of the event, resulting in a properly-signed, accurate
row delta to use in the statistics.

If an error occurs here, log it, but do not surface this as an
actual error .. simply assume the DML affected a row and move on. It
will be inaccurate, but this is already the case.

* Fix import

* update wording to warning log message

Co-authored-by: Tim Vaillancourt <[email protected]>
@dm-2 dm-2 had a problem deploying to production/mysql_role=ghost_testing July 7, 2022 15:24 Failure
@dm-2 dm-2 temporarily deployed to production/mysql_role=ghost_testing July 7, 2022 15:27 Inactive
meiji163
meiji163 previously approved these changes Jan 25, 2023
rashiq
rashiq previously approved these changes Oct 6, 2023
The base image is `buster` instead of previously assumed `stretch`
@rashiq rashiq temporarily deployed to production October 6, 2023 15:34 Inactive
@rashiq rashiq temporarily deployed to production October 6, 2023 15:36 Inactive
@rashiq rashiq temporarily deployed to production October 9, 2023 13:13 Inactive
@meiji163 meiji163 deployed to staff-wus2-01 March 11, 2024 19:40 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.