Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed DoesOrgExist to not retry when org exists (#952)
<!-- For the checkboxes below you must check each one to indicate that you either did the relevant task, or considered it and decided there was nothing that needed doing --> - [x] Did you write/update appropriate tests - [x] Release notes updated (if appropriate) - [x] Appropriate logging output - [x] Issue linked - [x] Docs updated (or issue created) - [x] New package licenses are added to `ThirdPartyNotices.txt` (if applicable) Fixes #944 `GithubApi.DoesOrgExist()` was working, but it was unnecessarily retrying 5 times when the org did exist before finally returning the correct response of `true`. It was likely written this way because it was copied from the implementation of `DoesRepoExist()`. The difference is when we check for the existence of the target repo we expect it to NOT exist (and if it does that API call will get retried 5 times probably unnecessarily, but should be rare enough that it's fine). But when checking for the target org we expect that it DOES exist, and don't want to retry in the case of success. <!-- For docs we should review the docs at: https://docs.github.com/en/early-access/github/migrating-with-github-enterprise-importer and the README.md in this repo If a doc update is required based on the changes in this PR, it is sufficient to create an issue and link to it here. The doc update can be made later/separately. The process to update the docs can be found here: https://github.com/github/docs-early-access#opening-prs The markdown files are here: https://github.com/github/docs-early-access/tree/main/content/github/migrating-with-github-enterprise-importer -->
- Loading branch information