fix: exclude API keys from agent when api-proxy is enabled

[Claude]

When api-proxy is enabled, ANTHROPIC_API_KEY and OPENAI_API_KEY were incorrectly passed to the agent container environment. These keys should only exist in the api-proxy sidecar, with the agent communicating via base_url pointing to the proxy.

Changes

• Environment variable filtering: Added conditional logic to exclude API keys from EXCLUDED_ENV_VARS set when config.enableApiProxy is true and keys are present
• Selective pass-through: Modified the default behavior (non---env-all case) to conditionally add ANTHROPIC_API_KEY only when api-proxy is NOT enabled

Implementation

Detection uses the same condition as api-proxy service creation:

const willUseApiProxy = config.enableApiProxy && (config.openaiApiKey || config.anthropicApiKey);
if (willUseApiProxy) {
  EXCLUDED_ENV_VARS.add('ANTHROPIC_API_KEY');
  EXCLUDED_ENV_VARS.add('OPENAI_API_KEY');
}

This ensures both --env-all and selective pass-through respect the api-proxy architecture.

[Copilot]

Pull request overview

This PR aims to fix a security issue where API keys were incorrectly passed to the agent container when api-proxy is enabled. The api-proxy sidecar architecture requires that API keys exist only in the sidecar container, with the agent communicating via BASE_URL environment variables pointing to the proxy.

Changes:

• Added logic to exclude ANTHROPIC_API_KEY and OPENAI_API_KEY from EXCLUDED_ENV_VARS when api-proxy is enabled (for --env-all mode)
• Modified selective pass-through to conditionally add ANTHROPIC_API_KEY only when api-proxy is NOT enabled

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Inconsistency: OPENAI_API_KEY is missing from the selective pass-through logic. While ANTHROPIC_API_KEY is conditionally passed to the agent only when api-proxy is NOT enabled (lines 397-401), there is no equivalent handling for OPENAI_API_KEY.

This creates an asymmetry where:

• If api-proxy is disabled: ANTHROPIC_API_KEY is passed to agent, but OPENAI_API_KEY is not (unless using --env-all)
• If api-proxy is enabled: Neither key should be passed (correctly handled for ANTHROPIC_API_KEY)

To maintain consistency with the api-proxy architecture and to support OpenAI usage without api-proxy, consider adding similar logic for OPENAI_API_KEY after line 401.

Suggested change

	}
	}
	// OpenAI API key for OpenAI-based models
	// Only pass OPENAI_API_KEY to agent when api-proxy is NOT enabled
	// When api-proxy IS enabled, the key goes to the sidecar only (not to agent)
	if (process.env.OPENAI_API_KEY && !willUseApiProxy) {
	environment.OPENAI_API_KEY = process.env.OPENAI_API_KEY;
	}

[Copilot]

Missing test coverage: The changes introduce important security logic to exclude API keys from the agent environment when api-proxy is enabled. However, there are no tests verifying that ANTHROPIC_API_KEY and OPENAI_API_KEY are actually excluded from the agent environment when api-proxy is enabled.

Consider adding test cases that:

1. Verify ANTHROPIC_API_KEY is NOT in agent.environment when api-proxy is enabled and anthropicApiKey is provided
2. Verify OPENAI_API_KEY is NOT in agent.environment when api-proxy is enabled and openaiApiKey is provided
3. Test the --env-all scenario to ensure API keys are excluded even when envAll is true

[Copilot]

The condition for willUseApiProxy (line 325) is inconsistent with the condition used to create the api-proxy service (line 917 and elsewhere). The willUseApiProxy check is:

config.enableApiProxy && (config.openaiApiKey || config.anthropicApiKey)

But the api-proxy service creation check is:

config.enableApiProxy && networkConfig.proxyIp && (config.openaiApiKey || config.anthropicApiKey)

This creates a discrepancy: if networkConfig.proxyIp is falsy, API keys would be excluded from the agent environment but no api-proxy service would be created. While proxyIp appears to always be set in practice (line 1099), the logic should be consistent. Consider adding the networkConfig.proxyIp check to the willUseApiProxy condition for consistency and defensive programming.