-
Notifications
You must be signed in to change notification settings - Fork 6
fix: update testPathPattern to testPathPatterns for Jest 30 #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
✅ Coverage Check PassedOverall Coverage
Coverage comparison generated by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the chroot integration test GitHub Actions workflow to use Jest 30’s renamed CLI flag so the chroot test jobs can run successfully after the Jest upgrade.
Changes:
- Replaced
--testPathPatternwith--testPathPatternsin the chroot integration test workflow. - Applied the flag update across the languages, package-managers, and edge-cases chroot test jobs.
Comments suppressed due to low confidence (2)
.github/workflows/test-chroot.yml:202
- This step uses
--testPathPatterns, but the repo dependency state in this PR still resolves Jest 29.7.0 (per package-lock / package.json), where the CLI flag is--testPathPattern. Please ensure the Jest 30 bump is part of the branch you’re merging into (or update this command to work with the installed Jest version).
npm run test:integration -- --testPathPatterns="chroot-package-managers" --verbose
.github/workflows/test-chroot.yml:258
- Same issue as the other jobs:
--testPathPatternsrequires Jest 30+, but this PR’s dependency files still indicate Jest 29.7.0. Either include/rebase onto the Jest 30 upgrade, or keep using the Jest 29 flag so the workflow matches the installed version.
npm run test:integration -- --testPathPatterns="chroot-edge-cases" --verbose
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| echo "=== Running chroot language tests ===" | ||
| npm run test:integration -- --testPathPattern="chroot-languages" --verbose | ||
| npm run test:integration -- --testPathPatterns="chroot-languages" --verbose |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow now passes --testPathPatterns, but the repo currently pins Jest 29.x (package.json has jest: ^29.0.0 and package-lock resolves [email protected]). With Jest 29 the supported flag is --testPathPattern (singular), so this will break CI unless the Jest 30 upgrade is included/rebased in this PR (or the command is made compatible with both versions).
This issue also appears in the following locations of the same file:
- line 202
- line 258
Deno Build Test Results
Overall: ✅ PASS All Deno tests passed successfully.
|
Node.js Build Test Results
Overall: PASS ✅ All Node.js projects successfully installed dependencies and passed their test suites.
|
C++ Build Test Results
Overall: PASS ✅ All C++ projects built successfully.
|
|
Smoke Test Results: PASS
|
|
Smoke Test Results (run 21882478550) ✅ GitHub MCP: Retrieved last 2 merged PRs (#581, #570) Status: PASS cc @Mossaka
|
Go Build Test Results
Overall: PASS ✅ All Go projects built and tested successfully.
|
Build Test: Java - FAILED ❌Status: ENVIRONMENT ERROR Error DetailsMaven is installed but non-functional in the workflow environment:
Test Results
Overall: FAIL Action RequiredThe workflow environment needs Maven to be properly configured or reinstalled with the correct architecture to execute JAR files.
|
Build Test: Bun - ❌ FAILEDEnvironment Issue Detected: Bun runtime is incompatible with the current GitHub Actions environment. Test Results
Overall: ❌ FAIL Error Details
Diagnostic OutputRecommendations
This is an infrastructure compatibility issue, not a code issue with the PR.
|
Jest 30 (upgraded in PR #580) renamed --testPathPattern to --testPathPatterns, breaking all 3 chroot integration test jobs. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
c3e1fb3 to
927b2da
Compare
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
C++ Build Test ResultsAll C++ projects built successfully! ✅
Overall: PASS 🎉
|
Build Test: Bun ✅
Overall: PASS ✅ All Bun projects built and tested successfully.
|
Smoke Test Results for Run 21882985849Last 2 Merged PRs:
Test Results:
Status: PASS @Mossaka - All smoke tests passed!
|
Smoke Test Results: Claude Engine✅ GitHub MCP - Retrieved last 2 merged PRs:
✅ Playwright - GitHub page loaded, title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub" ✅ File Writing - Created ✅ Bash Tool - Verified file contents: "Smoke test passed for Claude at Tue Feb 10 21:27:40 UTC 2026" Overall: PASS ✅
|
Rust Build Test Results
Overall: PASS ✅ All Rust projects built and tested successfully.
|
|
Smoke Test Results
|
Go Build Test Results ✅
Overall: PASS ✅ All Go projects built and tested successfully.
|
☕ Java Build Test Results
Overall: ✅ PASS All Java projects successfully compiled and passed tests through the AWF firewall.
|
Summary
--testPathPatternto--testPathPatternstest-chroot.ymlfor the languages, package-managers, and edge-cases jobsTest plan
test-chroot-languagesjob passes in CItest-chroot-package-managersjob passes in CItest-chroot-edge-casesjob passes in CI🤖 Generated with Claude Code