Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flat config and upgrade eslint to v9 #571

Merged
merged 23 commits into from
Nov 20, 2024

Conversation

gracepark
Copy link
Contributor

@gracepark gracepark commented Nov 8, 2024

This allows us to support flat config and provides testing for both:

  • Upgrades the plugin to v9
  • Flat config
  • Legacy config remains in the same location
  • I've created test-examples which allows testing for both legacy and flat configs:
    • For legacy, run: npm run test-examples:legacy on 8.57 without flat config
    • For flat, run: npm run test-examples:flat on 8.57 with flat config

Testing

I used yalc to test this package with other repos:

  • clipboard-copy-element: This is on v8.42.0 and on legacy eslintrc.json config. I was able to "update" the eslint-plugin-github plugin and ran npm run lint and it ran as expected.
  • codeql-action: eslint is on 8.57.1 and on flat config. I was able to "update" the eslint-plugin-github, ran npm run lint and it ran as expected.

@gracepark gracepark self-assigned this Nov 12, 2024
@gracepark gracepark marked this pull request as ready for review November 12, 2024 15:58
@gracepark gracepark requested a review from a team as a code owner November 12, 2024 15:58
@gracepark gracepark changed the title Support flat config Support flat config and upgrade eslint to v9 Nov 13, 2024
README.md Show resolved Hide resolved
Copy link
Contributor

@manuelpuyol manuelpuyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love the new test examples and that you tested different repos 😄

@gracepark gracepark merged commit 3c52370 into main Nov 20, 2024
7 checks passed
@gracepark gracepark deleted the gracepark-support-flat-config branch November 20, 2024 22:49
@arelia arelia linked an issue Nov 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for flat config
2 participants