Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update typo in the sentence #34597

Merged
merged 2 commits into from
Sep 16, 2024
Merged

update typo in the sentence #34597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de3875c
update typo in the sentence
s-3ntinel Sep 16, 2024
8ba88c6
Merge branch 'main' into s-3ntinel-patch-1
nguyenalex836 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/code-security/secret-scanning/introduction/about-secret-scanning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

{% data variables.product.prodname_secret_scanning_caps %} is a security feature that helps detect and prevent the accidental inclusion of sensitive information such as API keys, passwords, tokens, and other secrets in your repository. When enabled, {% data variables.product.prodname_secret_scanning %} scans commits in repositories for known types of secrets and alerts repository administrators upon detection.

{% data variables.product.prodname_secret_scanning_caps %} scans your entire Git history on all branches present in your {% data variables.product.prodname_dotcom %} repository for secrets{% ifversion ghec or ghes %}, even if the repository is archived{% endif %}.{% ifversion ghes < 3.11 %} {% data variables.product.prodname_secret_scanning_caps %} does not scan issues.{% endif %}{% ifversion secret-scanning-backfills %} {% data variables.product.prodname_dotcom %} will also periodically run a full Git history scan of existing content in {% ifversion fpt %}public{% else %}{% data variables.product.prodname_GH_advanced_security %}{% endif %} repositories where {% data variables.product.prodname_secret_scanning %} is enabled.{% endif %}

Check warning on line 27 in content/code-security/secret-scanning/introduction/about-secret-scanning.md

View workflow job for this annotation

GitHub Actions / lint-content

Liquid `ifversion` (and `elsif`) should not always be true 

The Liquid ifversion condition 'secret-scanning-backfills' includes all possible versions and will always be true.

{% data reusables.secret-scanning.what-is-scanned %}

Expand Down Expand Up @@ -54,7 +54,7 @@

* **Review**: When a secret is detected, you'll need to review the alert details provided.

* **Remediation**: You then need take appropriate actions to remediate the exposure. This might include:
* **Remediation**: You then need to take appropriate actions to remediate the exposure. This might include:
* Rotating the affected credential to ensure it is no longer usable.
* Removing the secret from the repository's history (using tools like BFG Repo-Cleaner or {% data variables.product.prodname_dotcom %}'s built-in features).

Expand Down
Loading