Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify requirements for action-importer gitlab #34551

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

h3rmanj
Copy link
Contributor

@h3rmanj h3rmanj commented Sep 10, 2024

Why:

We sat for about 30 minutes trying different inputs for the command due to vague requirements for the arguments. This PR clarifies what inputs the --namespace and --project should be.

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • --namespace clarifies that using the full path for a subgroup is needed
  • --project specify project slug instead of project URL

Project slug is standard GitLab lingo when creating projects in GitLab.
image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Sep 10, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/migrating-to-github-actions/using-github-actions-importer-to-automate-migrations/migrating-from-gitlab-with-github-actions-importer.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 10, 2024
@nguyenalex836
Copy link
Contributor

@h3rmanj Thanks so much for opening a PR! I'll get this triaged for review ✨

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Sep 11, 2024
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

Copy link
Contributor

@jfine jfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a ✨ change since the update is more consistent with GitLab terminology...

Project slug: Enter the path to your project. GitLab uses the slug as the URL path.

From: https://docs.gitlab.com/ee/user/project/#create-a-blank-project

...and in this case the whole URL is not what is required.

@nguyenalex836 nguyenalex836 added ready to merge This pull request is ready to merge SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Oct 1, 2024
@nguyenalex836
Copy link
Contributor

@jfine Thank you for the review! ✨

@h3rmanj Thank you very much for this update! ✨ This repo is currently in a code freeze, but we will get this merged as soon as the freeze ends on 10/7! 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Oct 7, 2024
Merged via the queue into github:main with commit b885059 Oct 7, 2024
47 checks passed
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants