-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify requirements for action-importer gitlab #34551
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@h3rmanj Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a ✨ change since the update is more consistent with GitLab terminology...
Project slug: Enter the path to your project. GitLab uses the slug as the URL path.
From: https://docs.gitlab.com/ee/user/project/#create-a-blank-project
...and in this case the whole URL is not what is required.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
We sat for about 30 minutes trying different inputs for the command due to vague requirements for the arguments. This PR clarifies what inputs the
--namespace
and--project
should be.What's being changed (if available, include any code snippets, screenshots, or gifs):
--namespace
clarifies that using the full path for a subgroup is needed--project
specify project slug instead of project URLProject slug is standard GitLab lingo when creating projects in GitLab.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.