Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove information about working collaboratively in a codespace #34507

Closed
wants to merge 3 commits into from

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Sep 5, 2024

Why:

This PR omits information about Github users working collaboratively in a codespace as they don't need Live Share to do pair programming sessions.

Closes:

Closes #34390

What's being changed (if available, include any code snippets, screenshots, or gifs):

See below chart for reference

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/developing-in-a-codespace/index.md fpt
ghec
fpt
ghec
Removed: codespaces/developing-in-a-codespace/working-collaboratively-in-a-codespace.md n/a fpt
ghec
removed
codespaces/guides.md fpt
ghec
fpt
ghec
codespaces/overview.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Sep 5, 2024
@nguyenalex836
Copy link
Contributor

nguyenalex836 commented Sep 5, 2024

@CBID2 Hello! Thank you for submitting the PR! ✨ I'm attempting to get an update on the status of the linked issue, and whether we still need a PR for this - stay tuned!

@hubwriter
Copy link
Contributor

Apologies for the delay on this. I've now heard back from the developer that the changes to Live Share just affect the backend service being used. From the user point of view Live Share will still be available, so no changes are needed to the docs.

Thanks @CBID2 for picking up the docs issue, but we don't need to make these changes after all. I'm going to close this and the docs issue. Thank you for your work on this, even though it wasn't, as it turned out, required. Much appreciated. 🙇‍♂️

@hubwriter hubwriter closed this Sep 6, 2024
@CBID2 CBID2 deleted the removing-information branch September 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mention of Live Share from the Codespaces docs
3 participants