Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update how to disable unathenticated sign-ups #34476

Closed
wants to merge 1 commit into from

Conversation

balcsok
Copy link

@balcsok balcsok commented Sep 3, 2024

Why: Docs out of date

Closes: n/a

What's being changed (if available, include any code snippets, screenshots, or gifs):

Since the Enable sign-up button is no longer present in the Management Console UI, I propose to change the wording of the doc to say "Make sure to select Private mode"
image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Sep 3, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/managing-iam/using-built-in-authentication/disabling-unauthenticated-sign-ups.md ghes@ 3.14 3.13 3.12 3.11 3.10
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review administering a repo Content relating to administering a repo and removed triage Do not begin working on this issue until triaged by the team labels Sep 3, 2024
@nguyenalex836
Copy link
Contributor

@balcsok Thanks so much for opening a PR! I'll get this triaged for review ✨

maxgtr992

This comment was marked as spam.

maxgtr992

This comment was marked as spam.

@sophietheking
Copy link
Contributor

@balcsok 👋 Thanks for opening this PR and contributing to our docs, we really appreciate it!

The Enable sign-up option is visible on my GHES 3.14 instance (if you scroll down a little):

Screenshot of the Management Console of a GHES instance

What version of GHES are you on? 😄

@balcsok
Copy link
Author

balcsok commented Sep 5, 2024

Hi there! Thanks for checking. I'm on 3.14.0 - just updated recently.
image

I don't see the button, maybe it's missing due to a configuration? FWIW, I'm using SSO (MS Entra).
Including a screenshot, where I scrolled further, just to prove it's not there (for me, at least 😄):
image

@sophietheking
Copy link
Contributor

@balcsok Ahh, right. From the article, it looks like you can only disable authenticated sign-ups if you're using built-in authentication for your GHES instance, so that would explain the missing option in your Management Console. 😸

@nguyenalex836
Copy link
Contributor

@sophietheking Thank you for reviewing here! ✨

@balcsok Given the conversation above, I'll go ahead and close this issue 💛

If by chance you're looking for issues to pick up, take a look at our help wanted section to find open issues you can work on ✨

@balcsok balcsok deleted the patch-1 branch September 12, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
administering a repo Content relating to administering a repo content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants