-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify GITHUB_SHA for push event #34436
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@dannycjones Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
.../actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows.md
Outdated
Show resolved
Hide resolved
@dannycjones Thank you so much for your patience while our SME team reviewed! They found a small to the wording would offer increased clarity, which I have added as a suggestion 💛 Once that suggestion has been applied, we will be happy to get this merged! |
Co-authored-by: Alex Nguyen <[email protected]>
Thanks @nguyenalex836, I incorporated the feedback and also merged from |
@dannycjones Thank you for applying that suggestion! I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Simple clarification on the value of
GITHUB_SHA
forpush
event. It's fairly obvious but with this change, there's no room for ambiguity.What's being changed (if available, include any code snippets, screenshots, or gifs):
Just clarifying the content of
GITHUB_SHA
. First sentence underGITHUB_SHA
is newly added.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.