Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify GITHUB_SHA for push event #34436

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

dannycjones
Copy link
Contributor

@dannycjones dannycjones commented Aug 29, 2024

Why:

Simple clarification on the value of GITHUB_SHA for push event. It's fairly obvious but with this change, there's no room for ambiguity.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Just clarifying the content of GITHUB_SHA. First sentence under GITHUB_SHA is newly added.

Webhook event payload Activity types GITHUB_SHA GITHUB_REF
push Not applicable Commit pushed to the ref. When you delete a branch, the SHA in the workflow run (and its associated refs) reverts to the default branch of the repository. Updated ref

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Aug 29, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 29, 2024
@nguyenalex836
Copy link
Contributor

@dannycjones Thanks so much for opening a PR! I'll get this triaged for review ✨

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Sep 17, 2024
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@dannycjones Thank you so much for your patience while our SME team reviewed! They found a small to the wording would offer increased clarity, which I have added as a suggestion 💛

Once that suggestion has been applied, we will be happy to get this merged!

@nguyenalex836 nguyenalex836 added more-information-needed More information is needed to complete review SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Oct 8, 2024
@dannycjones
Copy link
Contributor Author

Thanks @nguyenalex836, I incorporated the feedback and also merged from main.

@nguyenalex836
Copy link
Contributor

@dannycjones Thank you for applying that suggestion! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 removed the more-information-needed More information is needed to complete review label Oct 9, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Oct 9, 2024
Merged via the queue into github:main with commit a179ab9 Oct 9, 2024
45 checks passed
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants