Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the ImprovedProxyCertificates feature-flag gate and makes the improved proxy CA certificate generation behavior the default for all runs of the start-proxy action.
Changes:
- Make
generateCertificateAuthorityalways apply the improved CA extensions and always sign with SHA-256. - Remove the
ImprovedProxyCertificatesfeature flag fromFeature/featureConfigand stop querying it instart-proxy-action. - Update unit tests to reflect the always-on certificate extensions.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/start-proxy/ca.ts | Always uses the improved CA extensions and SHA-256 signing; removes FF parameter. |
| src/start-proxy/ca.test.ts | Consolidates tests to assert the improved extensions are always present. |
| src/start-proxy-action.ts | Stops querying the removed feature flag; always uses the updated CA generation. |
| src/feature-flags.ts | Removes ImprovedProxyCertificates from the feature enum and config map. |
| lib/upload-sarif-action.js | Generated JS update reflecting feature flag removal. |
| lib/upload-sarif-action-post.js | Generated JS update reflecting feature flag removal. |
| lib/upload-lib.js | Generated JS update reflecting feature flag removal. |
| lib/start-proxy-action.js | Generated JS update reflecting CA generation signature + feature flag removal. |
| lib/start-proxy-action-post.js | Generated JS update reflecting feature flag removal. |
| lib/setup-codeql-action.js | Generated JS update reflecting feature flag removal. |
| lib/resolve-environment-action.js | Generated JS update reflecting feature flag removal. |
| lib/init-action.js | Generated JS update reflecting feature flag removal. |
| lib/init-action-post.js | Generated JS update reflecting feature flag removal. |
| lib/autobuild-action.js | Generated JS update reflecting feature flag removal. |
| lib/analyze-action.js | Generated JS update reflecting feature flag removal. |
| lib/analyze-action-post.js | Generated JS update reflecting feature flag removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the FF added in #3473 since this is now fully rolled out and appears to be stable.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist