Skip to content

Comments

Remove FF gate for connection checks#3503

Merged
mbg merged 1 commit intomainfrom
mbg/ff/make-connection-checks-default
Feb 24, 2026
Merged

Remove FF gate for connection checks#3503
mbg merged 1 commit intomainfrom
mbg/ff/make-connection-checks-default

Conversation

@mbg
Copy link
Member

@mbg mbg commented Feb 24, 2026

Removes the FF added in #3466 since this is now fully rolled out and appears to be stable.

Risk assessment

For internal use only. Please select the risk level of this change:

  • High risk: Changes are not fully under feature flags, have limited visibility and/or cannot be tested outside of production.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg self-assigned this Feb 24, 2026
@mbg mbg requested a review from a team as a code owner February 24, 2026 11:20
Copilot AI review requested due to automatic review settings February 24, 2026 11:20
@github-actions github-actions bot added the size/XS Should be very easy to review label Feb 24, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the StartProxyConnectionChecks feature flag that was introduced in PR #3466 to gate connection checks to private registries in the start-proxy action. The feature has been fully rolled out and is now stable, so the gate is no longer needed. The connection checks are now always performed.

Changes:

  • Removed the StartProxyConnectionChecks feature flag from the Feature enum and featureConfig object
  • Removed the feature flag check that gated the checkConnections call in start-proxy-action.ts
  • Updated all generated JavaScript files in lib/ to reflect the TypeScript changes

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/start-proxy-action.ts Removed feature flag check, now always calls checkConnections
src/feature-flags.ts Removed StartProxyConnectionChecks enum entry and config
lib/start-proxy-action.js Generated JS reflecting removal of feature flag check
lib/feature-flags.ts (via multiple lib/*.js files) Generated JS reflecting removal of feature flag definition
lib/upload-sarif-action.js Generated JS with removed feature flag definition
lib/upload-sarif-action-post.js Generated JS with removed feature flag definition
lib/upload-lib.js Generated JS with removed feature flag definition
lib/start-proxy-action-post.js Generated JS with removed feature flag definition
lib/setup-codeql-action.js Generated JS with removed feature flag definition
lib/resolve-environment-action.js Generated JS with removed feature flag definition
lib/init-action.js Generated JS with removed feature flag definition
lib/init-action-post.js Generated JS with removed feature flag definition
lib/autobuild-action.js Generated JS with removed feature flag definition
lib/analyze-action.js Generated JS with removed feature flag definition
lib/analyze-action-post.js Generated JS with removed feature flag definition

@mbg mbg merged commit 28737ec into main Feb 24, 2026
248 checks passed
@mbg mbg deleted the mbg/ff/make-connection-checks-default branch February 24, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants