Merge main into releases/v3 #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mergeback v3.28.2 refs/heads/releases/v3 into main
This is not the case when downloading the bundle from a GitHub Release synced to GHES with the CodeQL Action sync tool.
Bumps the npm_and_yarn group with 1 update: [undici](https://github.com/nodejs/undici). Updates `undici` from 5.28.4 to 5.28.5 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.4...v5.28.5) --- updated-dependencies: - dependency-name: undici dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>
…yarn-2c579f9325 build(deps): bump undici from 5.28.4 to 5.28.5 in the npm_and_yarn group
Update default bundle to 2.20.2
…tion Fix assumption that download URLs contain file extension
Temporarily disable uploading debug artifacts
angelapwen
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Copilot reviewed 13 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (7)
- lib/defaults.json: Language not supported
- package.json: Language not supported
- src/defaults.json: Language not supported
- lib/tools-download.js: Evaluated as low risk
- src/tools-download.ts: Evaluated as low risk
- lib/debug-artifacts.js: Evaluated as low risk
- src/debug-artifacts.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)
src/tar.ts:221
- Ensure that the new behavior for inferring compression methods is covered by tests.
export function inferCompressionMethod(
lib/tar.js:198
- The error message when the compression method cannot be inferred should be more descriptive. Consider changing it to:
Could not infer compression method from path ${tarPath}. Please specify a path ending in '.tar.gz' or '.tar.zst'.
return undefined;
lib/tar.js:194
- The
inferCompressionMethodfunction should correctly handle the file extensions without the extra dot. Change.${ext}to${ext}.
if (tarPath.endsWith(`.${ext}`)) {
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 23ec3af into
releases/v3.Conductor for this PR is @angelapwen.
Contains the following pull requests:
Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.