Fix issues showing autocomplete results in Firefox #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camertron
force-pushed
the
fix_firefox
branch
from
7699413 to
aa55cc1
Compare
camertron
commented
Feb 20, 2024
10 tasks
keithamus
approved these changes
Feb 21, 2024
camertron
force-pushed
the
fix_firefox
branch
from
aa55cc1 to
a6a233b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an interesting issue last week that was causing weirdness showing autocomplete results that use the popover API:
Before:
before.mov
After:
after.mov
The issue seemed to be that, when a list item was clicked, focus would return to the text input. Focusing the input kicked off a request to fetch results, which displayed the list again. There is already code to handle this case, but it was being applied when the input was focused rather than blurred. This PR inverts the logic for popovers, but keeps it the same for non-popovers. I believe this is because the input's blur event does not fire when a popover appears.