replace on-ready setup-vpcs / setup-peerings / test-connectivity with basic release test scenario#1290
Open
edipascale wants to merge 2 commits intomasterfrom
Open
replace on-ready setup-vpcs / setup-peerings / test-connectivity with basic release test scenario#1290edipascale wants to merge 2 commits intomasterfrom
edipascale wants to merge 2 commits intomasterfrom
Conversation
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
from
c2c7d6c to
8b473d9
Compare
edipascale
force-pushed
the
ema/release-test-reorg
branch
2 times, most recently
from
0c887ee to
e3be2ee
Compare
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
from
8b473d9 to
0558c3c
Compare
Contributor
Author
|
realized this doesn't cover gateway, which is added in the onReady setup-peerings if the gateway is enabled, so I gotta add at least that before this can get in. moving back to draft |
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
3 times, most recently
from
dd49b9f to
5762ffb
Compare
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
from
5762ffb to
2e6a1d0
Compare
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
from
2e6a1d0 to
0aa4220
Compare
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
from
0aa4220 to
2346c5c
Compare
Contributor
Author
|
moving to draft as we discussed changes we want to make to extend the coverage of the test, specifically for VLAB |
Frostman
requested changes
Feb 19, 2026
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
7 times, most recently
from
63cfb04 to
ac23915
Compare
There was a problem hiding this comment.
Pull request overview
This PR replaces the previous VLAB “on-ready” CI actions (setup-vpcs, setup-peerings, test-connectivity) with a minimal “always-on” release-test scenario by introducing a dedicated on-ready release-test suite and wiring it into both hhfab vlab up --ready=release-test and the GitHub Actions workflow.
Changes:
- Add an “OnReady-only” release-test suite (
rt_on_ready_suite.go) and aReleaseTestOpts.OnReadyTestswitch to run only that suite. - Add CLI/workflow plumbing to trigger the on-ready-only suite in CI (
--release-test-on-ready-only/--on-ready-only). - Update host-BGP server command generation to include VLAN and adjust VLAN allocation behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/hhfab/vlabrunner.go |
Passes through an on-ready-only flag into release-test execution during --ready=release-test. |
pkg/hhfab/testing.go |
Updates host-BGP command generation signature/format and VLAN allocation flow; adds OnReadyTest option to ReleaseTestOpts. |
pkg/hhfab/rt_on_ready_suite.go |
Introduces the new on-ready release-test suite that builds ad-hoc VPCs/peerings and runs connectivity checks. |
pkg/hhfab/rt_base.go |
Adds gwSupported to test context and routes execution to only the on-ready suite when requested; refactors recap/report writing. |
cmd/hhfab/main.go |
Adds CLI flags to select the on-ready-only suite for both VLAB on-ready and direct release-test command usage. |
.github/workflows/run-vlab.yaml |
Switches default CI flow to run --ready=release-test with the on-ready-only suite (non-upgrade path) and updates VLAB generation parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edipascale
force-pushed
the
ema/basic-rt-scenario
branch
from
ac23915 to
9a5f752
Compare
adapt to the new syntax for multi-vpcs, even though right now we keep supporting only a single vpc Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
make it a special test which is only run if explicitly requested, disabling all other tests. the new test attempts to cover as much ground as possible given the limitations of virtual switches, and fails if any of the desired functionalities to test are not present or supported, to make sure we do not accidentally skip it and miss breaking changes. the only exception is that we must still support deployments with no gateway, so gateway peerings are skipped if it is not enabled. upgrade jobs still use the old setup as they do not support some of the things we need, such as static externals. Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
pau-hedgehog
force-pushed
the
ema/basic-rt-scenario
branch
from
9a5f752 to
c18f6e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1139
Fix #1360
Fix #1362
Fix #1363