Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #45

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Upgrade dependencies #45

merged 2 commits into from
Oct 25, 2021

Conversation

lekhmanrus
Copy link
Collaborator

@lekhmanrus lekhmanrus commented Oct 20, 2021

No description provided.

@lekhmanrus lekhmanrus requested a review from RussKie October 20, 2021 16:41
@RussKie
Copy link
Member

RussKie commented Oct 21, 2021

Two issues:

  1. The PR contains unrelated changes
  2. Git Extensions v2.x-3.5 are all build against net461. The current dev version is targeting .NET 5.0. Why do you think we need to bump to net48?

@lekhmanrus
Copy link
Collaborator Author

lekhmanrus commented Oct 21, 2021

  1. removed
  2. my bad, sorry. I thought Git Extensions used net48 because current System.ValueTuple conflicts are between MSBuild and GitExtensions:
Warnings
    References which depend on "System.ValueTuple, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\Microsoft.NET.Build.Extensions\net461\lib\System.ValueTuple.dll].
        C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\Microsoft.NET.Build.Extensions\net461\lib\System.ValueTuple.dll
    References which depend on "System.ValueTuple, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" [C:\Program Files (x86)\GitExtensions\System.ValueTuple.dll].
        C:\Program Files (x86)\GitExtensions\GitCommands.dll
        ...

I tried to add bindingRedirect to app.config, but it doesn't fix the warnings. When I was upgraded to .net48 warnings were gone.
Currently, I've reverted .net48 and just upgraded solution dependencies.

@lekhmanrus lekhmanrus changed the title Upgrade to .net framework 4.8 Upgrade dependencies Oct 21, 2021
@lekhmanrus
Copy link
Collaborator Author

Do you have any input on how to fix System.ValueTuple conflicts related to #44?

@RussKie
Copy link
Member

RussKie commented Oct 23, 2021

If it isn't a problem at runtime I wouldn't spend too much time on this. The next version of the app is targeting .NET 5.0 (right now), that's where I'd concentrate.

@lekhmanrus
Copy link
Collaborator Author

@RussKie, So we can migrate the Gerrit plugin to .Net 5 now? Does GitExtensions.Extensibility target to .net 5 ?

@lekhmanrus lekhmanrus requested a review from RussKie October 23, 2021 23:59
@RussKie
Copy link
Member

RussKie commented Oct 24, 2021

@RussKie, So we can migrate the Gerrit plugin to .Net 5 now? Does GitExtensions.Extensibility target to .net 5 ?

gitextensions/gitextensions.extensibility#21

@lekhmanrus lekhmanrus merged commit 5e95991 into gitextensions:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants