Fix downloads: Filter out invalid releases #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The This is fixed now in that we'll probe the result out and filter out whatever doesn't match the output |
estib-vega
force-pushed
the
e-branch-1
branch
2 times, most recently
from
fab49a1 to
14433d3
Compare
apps/web/src/lib/types/releases.ts
Outdated
Comment on lines
46
to
65
| export function getValidReleases(something: unknown): Release[] { | ||
| if (!Array.isArray(something)) return []; | ||
| const result: Release[] = []; | ||
| for (const item of something) { | ||
| if (isRelease(item)) { | ||
| result.push(item); | ||
| continue; | ||
| } | ||
|
|
||
| // TODO: Add some metrics to this | ||
| console.warn('Invalid release:', item); | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
Should we be reporting this to Sentry?
There was a problem hiding this comment.
IMO yeah, do we already do that anywhere in the app? I'll look for an example of that
Comment on lines
+31
to
+46
| export function isRelease(something: unknown): something is Release { | ||
| return ( | ||
| typeof something === 'object' && | ||
| something !== null && | ||
| typeof (something as any).version === 'string' && | ||
| (typeof (something as any).notes === 'string' || (something as any).notes === null) && | ||
| typeof (something as any).sha === 'string' && | ||
| typeof (something as any).channel === 'string' && | ||
| typeof (something as any).build_version === 'string' && | ||
| typeof (something as any).released_at === 'string' && | ||
| Array.isArray((something as any).builds) && | ||
| (something as any).builds.every(isReleaseBuild) | ||
| ); | ||
| } |
There was a problem hiding this comment.
I would love that
Caleb-T-Owens
approved these changes
Jan 10, 2025
Parse and guard the response from the releases API to ensure the input is the one expected.
estib-vega
force-pushed
the
e-branch-1
branch
from
14433d3 to
3b66859
Compare
estib-vega
force-pushed
the
e-branch-1
branch
from
3b66859 to
61b185e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse and guard the response from the releases API to ensure the input is the one expected.