Improve front end error handling #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtsgrd
commented
Jan 10, 2025
mtsgrd
commented
- handles signing error in one place
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
mtsgrd
force-pushed
the
frontend-errors
branch
from
05f5582 to
5e4fd06
Compare
mtsgrd
force-pushed
the
frontend-errors
branch
from
5e4fd06 to
fb26bb7
Compare
- handles signing error in one place
mtsgrd
force-pushed
the
frontend-errors
branch
from
fb26bb7 to
8c3c843
Compare
|
@ndom91 this is just a small thing I did while working on other stuff. |
ndom91
approved these changes
Jan 13, 2025
estib-vega
reviewed
Jan 13, 2025
Comment on lines
10
to
11
| ? true | ||
| : false; |
There was a problem hiding this comment.
I think we can skip this two lines
| typeof err.message === 'string' && | ||
| 'code' in err && | ||
| typeof err.code === 'string') || | ||
| false |
There was a problem hiding this comment.
We can also skip this line
mtsgrd
force-pushed
the
frontend-errors
branch
from
8c3c843 to
a9a8da0
Compare
mtsgrd
force-pushed
the
frontend-errors
branch
from
a9a8da0 to
3e85f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.