Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for e2e tests on mac #4808

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Sep 1, 2024

Works with Tauri v2 - keeping as draft until #4789 has landed.


This is part 1 of 2 in a stack made with GitButler:

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:49am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:49am

@ndom91
Copy link
Contributor

ndom91 commented Sep 2, 2024

Pushed a small commit to merge some of the RUN commands to avoid creating new layers and cleaned up a few other things, hope thats alright 👍

@ndom91
Copy link
Contributor

ndom91 commented Sep 4, 2024

@mtsgrd I added a small GHA for building and publishing this Dockerfile like we'd talked about. We'll still need to adapt the CMD / ENTRYPOINT and anything else? 🤔

In a follow-up PR we can then update our test-e2e.yml webdriver job to use this image

@mtsgrd mtsgrd force-pushed the Add-Dockerfile-for-e2e-tests-on-mac branch from 1cf328d to 001817b Compare September 9, 2024 14:28
@mtsgrd mtsgrd force-pushed the Add-Dockerfile-for-e2e-tests-on-mac branch from 001817b to dba99df Compare December 4, 2024 21:29
@mtsgrd mtsgrd force-pushed the Add-Dockerfile-for-e2e-tests-on-mac branch from dba99df to 035832f Compare December 4, 2024 21:37
@mtsgrd mtsgrd marked this pull request as ready for review December 4, 2024 22:14
@mtsgrd mtsgrd force-pushed the Add-Dockerfile-for-e2e-tests-on-mac branch from 035832f to d106c44 Compare December 5, 2024 09:51
@mtsgrd mtsgrd force-pushed the Add-Dockerfile-for-e2e-tests-on-mac branch from d106c44 to 02c0124 Compare December 5, 2024 09:57
@mtsgrd mtsgrd requested a review from ndom91 December 9, 2024 14:07
@mtsgrd mtsgrd merged commit 92b5499 into master Dec 13, 2024
20 checks passed
@mtsgrd mtsgrd deleted the Add-Dockerfile-for-e2e-tests-on-mac branch December 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants