Skip to content

Commit

Permalink
new review_all data
Browse files Browse the repository at this point in the history
  • Loading branch information
@schacon
schacon committed Oct 4, 2024
1 parent 8b210c5 commit 5523562
Showing 1 changed file with 54 additions and 19 deletions.
73 changes: 54 additions & 19 deletions apps/web/src/routes/projects/[projectId]/branches/[branchId]/stack/+page.svelte
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@
<h2>Patches</h2>
{#each stackData.patches as patch}
<div class="patch">
{#if patch.review.rejected.length > 0}
{#if patch.review_all.rejected.length > 0}
<div class="patchHeader rejected">X</div>
{:else if patch.review.signed_off.length > 0}
{:else if patch.review_all.signed_off.length > 0}
<div class="patchHeader signoff">✓</div>
{:else}
<div class="patchHeader unreviewed">?</div>
Expand All @@ -104,23 +104,49 @@
.statistics.deletions}, Files: {patch.statistics.file_count}
</div>
<hr />
<div>
Viewed:
{#each patch.review.viewed as email}
<Gravatar {email} size={20} />
{/each}
</div>
<div>
Signed Off:
{#each patch.review.signed_off as email}
<Gravatar {email} size={20} />
{/each}
</div>
<div>
Rejected:
{#each patch.review.rejected as email}
<Gravatar {email} size={20} />
{/each}
<div class="columns">
<div class="column">
<h3>This Version</h3>
<div>
<div class="title">Viewed:</div>
{#each patch.review.viewed as email}
<Gravatar {email} size={20} />
{/each}
</div>
<div>
<div class="title">Signed Off:</div>
{#each patch.review.signed_off as email}
<Gravatar {email} size={20} />
{/each}
</div>
<div>
<div class="title">Rejected:</div>
{#each patch.review.rejected as email}
<Gravatar {email} size={20} />
{/each}
</div>
</div>
<div class="column">
<h3>All Versions</h3>
<div>
<div class="title">Viewed:</div>
{#each patch.review_all.viewed as email}
<Gravatar {email} size={20} />
{/each}
</div>
<div>
<div class="title">Signed Off:</div>
{#each patch.review_all.signed_off as email}
<Gravatar {email} size={20} />
{/each}
</div>
<div>
<div class="title">Rejected:</div>
{#each patch.review_all.rejected as email}
<Gravatar {email} size={20} />
{/each}
</div>
</div>
</div>
</div>
</div>
Expand All @@ -135,6 +161,10 @@
h2 {
font-size: 1.5rem;
}
h3 {
font-size: 1.1rem;
font-weight: bold;
}
.columns {
display: flex;
}
Expand Down Expand Up @@ -169,4 +199,9 @@
background-color: rgb(215, 215, 144);
color: black;
}
.title {
min-width: 100px;
display: inline-block;
border-right: 1px solid #eee;
}
</style>

0 comments on commit 5523562

Please sign in to comment.