Fix memory leak / performance degradation #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every re-render,
update()
method was callingthis.append(list)
, that kept adding the rows widgets to the MainPanel over and over again, without ever cleaning up.You could see the performance degradation when moving back and forth through the log list – the more you moved, the slower it became, to the point of unusability.
Cleaning up the list of children of MainPanel before re-adding the updated rows fixed the issue.