Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Emails): ajout du User ou Siae dans les TemplateTransactionalSendLogs #1352

Merged

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Jul 18, 2024

Quoi ?

Suite à #1337

  • rattacher les logs à leur User ou Siae correspondantes (generic foreign key)
  • 2e GFK pour stocker l'objet parent (TenderSiae, SiaeUserRequest, Tender)
  • et j'ai mis à jour l'admin pour intégrer les stats (count coté User, Siae & TemplateTransactional)

@raphodn raphodn changed the title refactor(Emails): ajout de l'objet dans les TemplateTransactionalSendLogs refactor(Emails): ajout du User ou Siae dans les TemplateTransactionalSendLogs Jul 19, 2024
Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG ! juste une petite coquille ;)


def parent_object_id_with_link(self, obj):
if obj.parent_content_type and obj.parent_object_id:
if obj.recipient_content_type.model == "tender":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que tu voulais le "parent_content_type" ici.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merciii

@raphodn raphodn merged commit 88fa396 into master Jul 25, 2024
8 checks passed
@raphodn raphodn deleted the raphodn/template-transactional-send-logs-content-object branch July 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants