Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Besoins): Mise à jour de la deuxième question pour la mesure d'impact #1296

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

SebastienReuiller
Copy link
Contributor

Quoi ?

Changement de la deuxième question en liste déroulante grâce aux enseignements tirés du champs libre.

Pourquoi ?

Pour pouvoir s'attribuer de l'incrémentale selon la réponse.

Comment ?

Passer le champs libre en liste déroulante.

Captures d'écran

Avant :

eval_impact_avant

Après :

update_question_impact

@github-actions github-actions bot requested review from madjid-asa and raphodn June 21, 2024 16:40
@SebastienReuiller SebastienReuiller changed the title feat(Besoins) : Mise à jour de la deuxième question pour la mesure d'impact feat(Besoins): Mise à jour de la deuxième question pour la mesure d'impact Jun 21, 2024
Copy link
Contributor

@raphodn raphodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG !

@@ -180,6 +180,40 @@
(SURVEY_SCALE_QUESTION_3, "Oui"),
)

SURVEY_DOESNT_EXIST_QUESTION_DONT_KNOW = "i-dont-know"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est-ce que la bonne pratique ca ne serait pas de stocker des mots en majuscule ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ou mieux commencer à le mettre en francais ? ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai refait avec un TextChoices, ça me parait bien plus lisible. Qu'en penses-tu @raphodn ?

@SebastienReuiller SebastienReuiller force-pushed the sreuiller/tender-update-survey branch from 4abcd9c to 6ed18c6 Compare June 26, 2024 15:43
@SebastienReuiller SebastienReuiller merged commit 0e8c240 into master Jul 1, 2024
8 checks passed
@SebastienReuiller SebastienReuiller deleted the sreuiller/tender-update-survey branch July 1, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants